Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module build failed: TypeError: node.serializeToString is not a function #25

Closed
leshek-pawlak opened this issue Jan 11, 2016 · 8 comments

Comments

@leshek-pawlak
Copy link

Hi guys!
First thing - this plugin is awesome!
Second thing - I've got this error after node update to version 5.3.0. (npm 3.5.2)

ERROR in ./~/css-loader!./~/postcss-loader!./css/main.css Module build failed: TypeError: node.serializeToString is not a function at XMLSerializer.serializeToString (node_modules/xmldom/dom.js:906:7) at SVGImage._addSprite (node_modules/postcss-svg/dist/lib/svg_image.js:199:40) at SVGImage._parseNode (node_modules/postcss-svg/dist/lib/svg_image.js:143:20) at SVGImage._parseNode (node_modules/postcss-svg/dist/lib/svg_image.js:148:16) at SVGImage._parseSvg (node_modules/postcss-svg/dist/lib/svg_image.js:99:18) at new SVGImage (node_modules/postcss-svg/dist/lib/svg_image.js:31:12) at Object.module.exports.addToIndex (node_modules/postcss-svg/dist/lib/svg_cache.js:65:15) at Object.module.exports.init (node_modules/postcss-svg/dist/lib/svg_cache.js:25:14) at node_modules/postcss-svg/dist/index.js:24:16 at LazyResult.run (node_modules/postcss/lib/lazy-result.js:206:20) at node_modules/postcss/lib/lazy-result.js:120:37 at LazyResult.asyncTick (node_modules/postcss/lib/lazy-result.js:134:15) at node_modules/postcss/lib/lazy-result.js:132:27 at LazyResult.asyncTick (node_modules/postcss/lib/lazy-result.js:134:15) at node_modules/postcss/lib/lazy-result.js:132:27 at LazyResult.asyncTick (node_modules/postcss/lib/lazy-result.js:134:15) at node_modules/postcss/lib/lazy-result.js:132:27 at LazyResult.asyncTick (node_modules/postcss/lib/lazy-result.js:134:15) at node_modules/postcss/lib/lazy-result.js:132:27 at LazyResult.asyncTick (node_modules/postcss/lib/lazy-result.js:134:15) at node_modules/postcss/lib/lazy-result.js:132:27 at LazyResult.asyncTick (node_modules/postcss/lib/lazy-result.js:134:15) @ ./css/main.css 4:14-117 13:2-17:4 14:20-123

@andreychev
Copy link

I am observing the same mistake.

Another issue: #24.
Update: jindw/xmldom#148.

@kvz
Copy link
Contributor

kvz commented Jan 11, 2016

kvz added a commit to transloadit/uppy that referenced this issue Jan 11, 2016
@kvz kvz mentioned this issue Jan 11, 2016
@kvz
Copy link
Contributor

kvz commented Jan 11, 2016

Proposed this change ---^ to shield the project from issues like these.

Until that is merged, or the problem is fixed another way, feel free to use

"postcss-svg": "https://github.com/kvz/postcss-svg#9239b6dd4ab0dc3ef37f41c9cbc0e23d25549c7b",

in your package.json to fix this issue in your projects @andreychev and @lesyek

@krizka
Copy link

krizka commented Jan 13, 2016

@kvz Thanks for the fix!

@leshek-pawlak
Copy link
Author

@kvz Great job! Thanks! 👍

@andreychev
Copy link

@kvz 👍

@tgfjt
Copy link

tgfjt commented Jan 13, 2016

xmldom was fixed v0.1.21 👍

@jonathantneal
Copy link
Collaborator

This plugin now uses xmldoc 1.1.0. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants