Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for "unwanted scrolling when inside collapsible" #1176

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Fix for "unwanted scrolling when inside collapsible" #1176

merged 6 commits into from
Aug 30, 2023

Commits on Aug 30, 2023

  1. typo

    @thet
    thet committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8835ac6 View commit details
    Browse the repository at this point in the history

  2. maint(pat-stacks): Adapt code to Patternslib standards.

    @thet
    thet committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    2f95379 View commit details
    Browse the repository at this point in the history

  3. feat(core dom): Add dom.element_uuid to get/set an uuid to a DOM node.

    @thet
    thet committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a7e5de1 View commit details
    Browse the repository at this point in the history

  4. breaking(pat-scroll): Remove implicit and unpreventable scroll suppor… 

    …t for pat-stacks.

With a pat-scroll as parent of a pat-stacks enabled navigation anchors,
the page would scroll to the target configured for pat-scroll. This
behavior could not be prevented and led to unwanted effects when using
pat-stacks inside pat-collapsible which itself uses pat-scroll when
configured properly.

This commit removes the scrolling support for pat-stacks within
pat-scroll in favor of an explicit and configurable scrolling behavior
in pat-stacks itself.
    @thet
    thet committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    92e1e6b View commit details
    Browse the repository at this point in the history

  5. feat(pat-stacks): Add configurable scroll support. 

    Add "scroll-selector" and "scroll-offset" arguments to pat-stacks,
likewise as in pat-collapsible. "scroll-selector" accepts a CSS selector
string or the special values "self" to scroll to the element itself and
"none" to block any scrolling behavior from parent pat-stacks configuration
options.

With these configuration options you can control the scrolling behavior
for pat-stacks on a fine-grained level.
    @thet
    thet committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    a8aae63 View commit details
    Browse the repository at this point in the history

  6. feat(pat stacks): Add a destroy method to unregister event handlers.

    @thet
    thet committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    8479cfa View commit details
    Browse the repository at this point in the history