Fix for "unwanted scrolling when inside collapsible" #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
force-pushed
the
scrum-1455--scroll
branch
from
2d42d7f
to
aef17ea
Compare
…t for pat-stacks. With a pat-scroll as parent of a pat-stacks enabled navigation anchors, the page would scroll to the target configured for pat-scroll. This behavior could not be prevented and led to unwanted effects when using pat-stacks inside pat-collapsible which itself uses pat-scroll when configured properly. This commit removes the scrolling support for pat-stacks within pat-scroll in favor of an explicit and configurable scrolling behavior in pat-stacks itself.
Add "scroll-selector" and "scroll-offset" arguments to pat-stacks, likewise as in pat-collapsible. "scroll-selector" accepts a CSS selector string or the special values "self" to scroll to the element itself and "none" to block any scrolling behavior from parent pat-stacks configuration options. With these configuration options you can control the scrolling behavior for pat-stacks on a fine-grained level.
thet
force-pushed
the
scrum-1455--scroll
branch
from
aef17ea
to
8479cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: scrum-1455