Pseudo Permanent Fix for "ElementalHitSkeletonKnight" #6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulet Added Leadership's Price Unique Amulet Wires77 said to put @Cinnabarit here i guess?
"{tags:critical}{variant:10,11,12,13,14,15,16}2% additional Chance to receive a Critical Strike"
This mod has not been in the game since 3.6, so this should clean up the mod-list visually.
what it says
A Scuffed but functional Fix for Vaal Slayer & Newly Added Colossal Vaal Fallen Method to the fix is to take the inherit "physical" (its not supposed to be physical) damage and then convert 100% of that damage into each element while flagging DealNoPhysical and DealNoChaos to emulate hitting with the skill repeatedly. there are some problems with this however, such as how this skill is used by both Projectile Spectre aswell as Melee Area Spectre as well as flat phys scaling your damage (it wont in game) so your damage can get inflated, however this is the best we can do atm until someone more capable comes along to fix this skill properly, untill then this will relatively properly convey your overall dps with Elemental Hit.
Nightblade
reviewed
Aug 19, 2023
This reverts commit 3601736.
Torchery
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Scuffed but functional Fix for Vaal Slayer & Newly Added Colossal Vaal Fallen
Method to the fix is to take the inherit "physical" (its not supposed to be physical) damage and then convert 100% of that damage into each element while flagging DealNoPhysical and DealNoChaos to emulate hitting with the skill repeatedly.
there are some problems with this however, such as how this skill is used by both Projectile Spectre aswell as Melee Area Spectre as well as flat phys scaling your damage (it wont in game)
so your damage can get inflated, however this is the best we can do atm until someone more capable comes along to fix this skill properly, untill then this will relatively properly convey your overall dps with Elemental Hit.