PCH Excerpt Generator: Update UI #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaurdan
reviewed
Mar 5, 2024
vaurdan
reviewed
Mar 5, 2024
vaurdan
reviewed
Mar 5, 2024
|
@vaurdan, thanks for your feedback. I have addressed as indicated. Feel free to take a look again 🙂 |
vaurdan
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refreshes the UI of our PCH Excerpt Generator feature. It also implements a loading animation as described here.
Deviations from design proposal
WRITE AN EXCERPT (OPTIONAL)textarea label was left as-is, since this value matches the WordPress default (we can change it if needed). Because the given text this is a label, it cannot have two colors and custom spacing without weird workarounds.Learn more about manual excerptslink has been added, since it opens in external mode (we can change it if needed).Motivation and context
How has this been tested?
Existing tests pass.
Screenshots
Current UI
Updated UI
Note: The button will display
Generate Excerptwhen in its initial state. If an excerpt is generated, the button will displayRegenerate Excerpt.