PCH: Redesign the PCH Editor Sidebar #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change sidebar icon styling * Improve SCSS comment --------- Co-authored-by: Alex Cicovic <[email protected]>
# Conflicts: # build/content-helper/editor-sidebar.asset.php # build/content-helper/editor-sidebar.css # build/content-helper/editor-sidebar.js
This was referenced Feb 23, 2024
…pin-button Re-enable PCH Editor Sidebar pin/unpin button
* Add tab interface to the Editor Sidebar * Add build files * Fix E2E tests after renaming the Editor Sidebar * Editor_Sidebar: Simplify and improve typing * Push PCH Editor Sidebar settings to the bottom * PCH Editor Sidebar: Move Performance Details out of Panel component * Apply feedback suggestion --------- Co-authored-by: Alex Cicovic <[email protected]>
# Conflicts: # build/content-helper/editor-sidebar.asset.php # build/content-helper/editor-sidebar.js # src/content-helper/editor-sidebar/editor-sidebar.tsx # src/content-helper/editor-sidebar/tabs/sidebar-tools-tab.tsx
Content Helper: Update Editor Sidebar Settings
PCH Excerpt Generator: Update UI
* Redesign Smart Linking panels * Complete some DocBlocks --------- Co-authored-by: Alex Cicovic <[email protected]>
* Add first iteration of Related Posts UI * Clean-up old code and block comments * Fix integration tests * Fix failing E2E tests * Workaround for ToggleGroupControl animation issue * Add built files * Fix "Cannot unlock an object" test error * Fix failing structure test * Apply minor UI adjustments * Add built files * Delete build files * Re-add build files * Rebuild assets * Add missing `to_rem` calls on CSS * Add more missing `to_rem` --------- Co-authored-by: Alex Cicovic <[email protected]>
* Add first iteration of Related Posts UI * Clean-up old code and block comments * Fix integration tests * Fix failing E2E tests * Workaround for ToggleGroupControl animation issue * Add built files * Fix "Cannot unlock an object" test error * Fix failing structure test * Apply minor UI adjustments * Add Suggestions panel and redesigned both collapsable panels * Redesign the individual title suggestions components * Add Modal box to confirm title replacement * Implement the new loading state * Fix linting & add built files * Add built files * Update built files * Delete build files * Re-add build files * Rebuild assets * Add missing `to_rem` calls on CSS * Remove PinnedOpen and SuggestionsOpen settings * Add more missing `to_rem` * Fix documentation and CSS * Rebuild assets * Fix more missing `to_rem` --------- Co-authored-by: Alex Cicovic <[email protected]>
…beta-message Update Content Suggestions API Beta message
dabowman
reviewed
Mar 8, 2024
src/content-helper/editor-sidebar/performance-details/performance-details.scss
Outdated
Show resolved
Hide resolved
dabowman
reviewed
Mar 8, 2024
src/content-helper/editor-sidebar/performance-details/component.tsx
Outdated
Show resolved
Hide resolved
Closed
* Fix dropdown pop-over width * Fix spacing issues with the accordion sections * Removed `fill` from AiIcon * Update src/content-helper/common/css/common.scss Co-authored-by: Alex Cicovic <[email protected]> --------- Co-authored-by: Alex Cicovic <[email protected]>
Update screenshots and README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates all the work that has been done in the context of redesigning the Content Helper Editor Sidebar. This was a big amount of work touching many parts of our codebase, so it was made step by step in smaller PRs which are referenced in this PR's comments.
Side effects
Related PostsandPerformance Detailssections will be reset. Crafting a migration path for this would have taken time without important benefits.Motivation and context
Closes #2206.
How has this been tested?
Screenshots