Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pre-Commit dependencies update #8

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 1, 2024

Pre-Commit Dependencies updates required

There are pre-commit dependencies waiting to be updated. Please see the Files changed tab for details.

Please check results of pre-commit test run with these updates in comments below.

Generated automatically with GitHub Actions

@github-actions github-actions bot requested a review from a team as a code owner February 1, 2024 01:25
Copy link
Contributor Author

github-actions bot commented Feb 1, 2024

⛔ ☠️ ❌ The Pre Commit test run failed. See results here.

Copy link
Contributor

@sebastianczech sebastianczech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked new version of Checkov in pre-commit on local machine.
Currently pre-commit shows the problem with Terraform documentation, but it's because of white characters - fix for that I prepared in #7 .

If we merge at first #7 , then there will be no issues with changes in pre-commit and it can be also merged.

Besides that there are no new Checkov issues besides already known:

  • Check: CKV_AWS_289: "Ensure IAM policies does not allow permissions management / resource exposure without constraints"
  • Check: CKV_AWS_290: "Ensure IAM policies does not allow write access without constraints"
  • Check: CKV_AWS_355: "Ensure no IAM policies documents allow "*" as a statement's resource for restrictable actions"
  • Check: CKV_AWS_364: "Ensure that AWS Lambda function permissions delegated to AWS services are limited by SourceArn or SourceAccount"

and which were already mentioned in PaloAltoNetworks/terraform-aws-vmseries-modules#383 (comment) and which should be resolved in PaloAltoNetworks/terraform-aws-vmseries-modules#238

@sebastianczech sebastianczech merged commit 2e9f6e3 into main Feb 23, 2024
@sebastianczech sebastianczech deleted the pre-commit-dependencies-update branch February 23, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants