Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Introduce Terraform 1.6 and 1.7 in CI workflows, fix README and update test skeleton version #7

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

sebastianczech
Copy link
Contributor

@sebastianczech sebastianczech commented Jan 31, 2024

Description

PR delivers multiple improvements:

  • Terraform 1.6 and 1.7 is added in CI workflows
  • problem with white characters in README is fixed
  • version of terraform-modules-swfw-tests-skeleton is updated

Motivation and Context

  • Since this version of Terraform is officially supported by the modules, test should be run using this version.
  • With white characters there were issues with pre-commit (please check failed first /sca ChatOps command).
  • There were errors while executing tests (please check failed first /plan ChatOps command), so version of terraform-modules-swfw-tests-skeleton was increased (after renaming package from terraform-modules-vmseries-tests-skeleton)

How Has This Been Tested?

Changes was tested using ChatOps. Please check PR comments.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes if appropriate.
  • All new and existing tests passed.

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 31, 2024

/sca

Testing job ID: 7725450923
Job result: FAILURE

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 31, 2024

/help

ChatOPS built in help:

Currently supported commands include:

  • /sca - run all SCA tests via pre-commit
  • /validate - run terraform validate
  • /plan - plan the infrastructure (only examples)
  • /apply - deploy the infrastructure and destroy afterwards (only examples)
  • /idempotence - test idempotence: deploy, plan and destroy afterwards (only examples).

The 1st command does not take arguments, the remaining take two:

  • paths - a space delimitied list of module paths
  • tf_version - (optional, defaults to the latest available) a space delimited list of Terraform versions to test the infrastrucure against.

Examples:

# run idempotence tests on listed modules with Terraform versions: 1.2 (latest patch available), 1.4 (latest patch available), 1.5.4.
/idempotence paths="examples/combined_design examples/panorama_standalone" tf_version="1.2 1.4 1.5.4"
# run validation tests with the latest available Terraform version on listed modules.
/validate paths="modules/vmseries modules/vpc examples/combined_design"

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 31, 2024

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone" tf_version="1.7"

Testing job ID: 7725472191
Job result: FAILURE

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 31, 2024

/sca

Testing job ID: 7725549224
Job result: SUCCESS

@sebastianczech sebastianczech changed the title ci: Introduce Terraform 1.6 and 1.7 in CI workflows ci: Introduce Terraform 1.6 and 1.7 in CI workflows, fix README and update test skeleton version Jan 31, 2024
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 31, 2024

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone" tf_version="1.7"

Testing job ID: 7725593052
Job result: SUCCESS

@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 31, 2024

/idempotence paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone" tf_version="1.7"

Testing job ID: 7725615285
Job result: FAILURE
Job result: SUCCESS

@sebastianczech sebastianczech marked this pull request as ready for review January 31, 2024 11:57
@sebastianczech sebastianczech requested a review from a team as a code owner January 31, 2024 11:57
@sebastianczech
Copy link
Contributor Author

sebastianczech commented Jan 31, 2024

/plan paths="examples/centralized_design examples/centralized_design_autoscale examples/combined_design examples/combined_design_autoscale examples/isolated_design examples/isolated_design_autoscale examples/panorama_standalone examples/vmseries_standalone" tf_version="1.6"

Testing job ID: 7726031836
Job result: SUCCESS

Copy link
Contributor

@pimielowski pimielowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍

@sebastianczech sebastianczech merged commit 5f07d87 into main Feb 6, 2024
15 checks passed
@sebastianczech sebastianczech deleted the workflow-terraform-1-7 branch February 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants