fix(panos_bgp_peer_group): Fix for IBGP export next-hop options #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
### [2.17.3](v2.17.2...v2.17.3) (2023-07-11) ### Bug Fixes * **eda:** Make `custom_logger` argument optional ([#456](#456)) ([49ed307](49ed307)) * **panos_admpwd:** Fix success criteria and update example in docs ([#457](#457)) ([9ecdb65](9ecdb65)) * **panos_bgp_peer_group:** Fix for IBGP export next-hop options ([#459](#459)) ([9489fa2](9489fa2)) * **panos_ike_crypto_profile:** Update DH group choices ([#461](#461)) ([8194318](8194318)) * **panos_ipsec_profile:** Update DH group choices ([#462](#462)) ([1798a3b](1798a3b)) * **panos_software:** Modify valid sequence for downloads only ([#463](#463)) ([214c4bb](214c4bb))
|
🎉 This PR is included in version 2.17.3 🎉 The release is available on Ansible Galaxy and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for IBGP
export_nexthopchoices, addingoriginalwhich is a valid choice for IBGP.Note: The default for
export_nexthopis currentlyresolvewhich is not valid for IBGP. Users choosingtype: ibgpwill therefore need to explicitly chooseoriginaloruse-selfforexport_nexthop, leavingexport_nexthopundefined will cause an error. Changing the default forexport_nexthopwould constitute a breaking change, so this is why the PR's code is presented as just an extra choice, not a change to the default choice.Motivation and Context
Fixes #441
How Has This Been Tested?
Tested locally:
Screenshots (if appropriate)
Test success:
Types of changes
Checklist