Skip to content

Commit

Permalink
fix(panos_software): Modify valid sequence for downloads only (#463)
Browse files Browse the repository at this point in the history
  • Loading branch information
jamesholland-uk authored Jul 11, 2023
1 parent 9ecdb65 commit 214c4bb
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion plugins/modules/panos_software.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@
notes:
- Panorama is supported.
- Check mode is supported.
- When installing PAN-OS software, checking is performed by this module to
ensure the upgrade/downgrade path is valid. When using this module to only
download and not install PAN-OS software, the valid upgrade/downgrade path
checking is bypassed (in order to allow pre-downloading of PAN-OS software
images ahead of the installation time for multiple stage upgrades/downgrades).
extends_documentation_fragment:
- paloaltonetworks.panos.fragments.transitional_provider
options:
Expand Down Expand Up @@ -211,7 +216,7 @@ def main():
device.software.check()

if target != current:
if not is_valid_sequence(current, target):
if not is_valid_sequence(current, target) and install:
module.fail_json(
msg="Version Sequence is invalid: {0} -> {1}".format(
current, target
Expand Down

0 comments on commit 214c4bb

Please sign in to comment.