panos_bgp_peer_group export-nexthop 'resolve' is not an allowed keyword error for type: ibgp

[robobeaver6]

Describe the bug

The task:

- name: Create BGP Peer Group
  panos_bgp_peer_group:
    provider: "{{ provider }}"
    name: "Group_Name"
    type: "ibgp"
    enable: true

gives the error:

fatal: [lolnoobfw1]: FAILED! => changed=false 
  msg: |-
    Failed apply:  Group_Name-> type -> ibgp -> export-nexthop 'resolve' is not an allowed keyword
     Group_Name -> type -> ibgp -> export-nexthop is invalid

By setting either the type: "ebgp" or the export_nexthop: "use-self" will work.

Expected behavior

the cli has no export-nexthop setting when ibgp is used, the module shouldn't set it to "resolve", it shouldn't be present

Current behavior

It throws the error unless use-self is set which is somewhat meaningless as it is not an option on the CLI

Possible solution

don't set or require the variable export-nexthop when type: ibgp is set

Steps to reproduce

run the task above

Context

I am templating the config of our remote devices using ansible because Panorama templates don't provide variables to all the parameters required.

Your Environment

• Collection: paloaltonetworks.panos
• Python: 3.9
• Ansible: 2.14.4

[welcome-to-palo-alto-networks]

🎉 Thanks for opening your first issue here! Welcome to the community!

[robobeaver6]

An additonal thing to note is that the ibgp mode should have an option of setting export-nexthop: "original" or export_nexthop: "use-self" The default in this case should be "original"

[jamesholland-uk]

Hi @robobeaver6, thanks for bringing this to our attention. Agreed that the ibgp option original is not catered for at present, only use-self and resolve are valid choices per the code currently in this module. We can easily add 'original' as an option such that ibgp can be configured properly (as it requires either original or use-self), but changing the default for this parameter would apply to both ibgp and ebgp, and it would constitute a breaking change and a new major version (i.e. v3.0.0) so we would prefer to leave the default as-is for now.

[github-actions]

🎉 This issue has been resolved in version 2.17.3 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot