fix(panos_admpwd): Fix success criteria and update example in docs #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example commit messages:
|
github-actions bot
pushed a commit
that referenced
this pull request
Jul 11, 2023
### [2.17.3](v2.17.2...v2.17.3) (2023-07-11) ### Bug Fixes * **eda:** Make `custom_logger` argument optional ([#456](#456)) ([49ed307](49ed307)) * **panos_admpwd:** Fix success criteria and update example in docs ([#457](#457)) ([9ecdb65](9ecdb65)) * **panos_bgp_peer_group:** Fix for IBGP export next-hop options ([#459](#459)) ([9489fa2](9489fa2)) * **panos_ike_crypto_profile:** Update DH group choices ([#461](#461)) ([8194318](8194318)) * **panos_ipsec_profile:** Update DH group choices ([#462](#462)) ([1798a3b](1798a3b)) * **panos_software:** Modify valid sequence for downloads only ([#463](#463)) ([214c4bb](214c4bb))
|
🎉 This PR is included in version 2.17.3 🎉 The release is available on Ansible Galaxy and GitHub release
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix success criteria.
Update example in docs.
Motivation and Context
Fixes #433.
Per #433, previously the test for success was too generic and was detecting a failed result as success.
Whilst testing for this PR, the example in the documentation was noted to be incorrect since changes in Ansible functionality, so the example code has also been updated.
How Has This Been Tested?
Tested locally against VM-Series and Panorama.
Screenshots (if appropriate)
Example of a previous failure, that the module detected as success:
Example of success after the changes in this PR:
Types of changes
Checklist