panos_admpwd output detection

[tfwong36]

Describe the bug

panos_admpwd.py line 169-170 detects keyword 'success' to interpret if the commit is success, but 'success' also printed in failed cases. Therefore, the script interpret the state wrongly, the job is not actually completed.

For example, "Server error : Commit job was not queued since auto-commit not yet finished successfully. Please use "commit force" to schedule commit job\r\n[edit]"

Expected behavior

It is expected not to count the failed commit command as finished/changed state.

Current behavior

It counted a commit failed as finished/changed.

Possible solution

Change the expected keyword to a more specific keyword in panos_admpwd.py line 169, such as "committed successfully", etc.

Steps to reproduce

1. request restart system in panos
2. run the script with retries
3. make sure the script/the-commit-command run before the system startup auto commit

Screenshots

Context

I am using terraform to trigger ansible to change the admin password in Alibaba Cloud, which do not have option to set admin password at boostrap. This bug makes my further terraform script cannot configure the panos. I am hoping the ansible can retry if it met other error with keyword 'success'

Your Environment

• Collection: paloaltonetworks.panos
• Python: Python 3.10.6
• Ansible: ansible [core 2.14.5]
• PAN-OS Python Library & version (e.g. pandevice 0.14.0, pan-os-python 1.0.2): paramiko 2.12.0

[welcome-to-palo-alto-networks]

🎉 Thanks for opening your first issue here! Welcome to the community!

[github-actions]

🎉 This issue has been resolved in version 2.17.3 🎉

The release is available on Ansible Galaxy and GitHub release

Posted by semantic-release bot