Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error for div etc. with affine quantities #354

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Throw error for div etc. with affine quantities #354

merged 2 commits into from
Jun 15, 2020

Conversation

sostock
Copy link
Collaborator

@sostock sostock commented Jun 11, 2020 •
edited
Loading

Throws an AffineError when calling div, mod, rem etc. with one or more AffineQuantitys.

@sostock
Copy link
Collaborator Author

sostock commented Jun 11, 2020

I just noticed that something like div(5cm, 2) also doesn’t throw an error. Therefore I will close this PR and upload one that addresses this problem as well.

@sostock sostock closed this Jun 11, 2020
@sostock sostock reopened this Jun 14, 2020
@sostock sostock mentioned this pull request Jun 14, 2020
Open
@sostock
Copy link
Collaborator Author

sostock commented Jun 14, 2020

Reopened (see #350 (comment)).

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2020 •
edited
Loading

Codecov Report

Merging #354 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #354      +/-   ##
==========================================
+ Coverage   79.65%   79.78%   +0.12%     
==========================================
  Files          15       15              
  Lines        1175     1182       +7     
==========================================
+ Hits          936      943       +7     
  Misses        239      239
Impacted Files Coverage Δ
src/Unitful.jl 100.00% <ø> (ø)
src/quantities.jl 93.56% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb46922...7b7f1a5. Read the comment docs.

@ajkeller34 ajkeller34 merged commit 1bfdad7 into PainterQubits:master Jun 15, 2020
briochemc added a commit to briochemc/Unitful.jl that referenced this pull request Aug 10, 2020
@briochemc
Merge remote-tracking branch 'upstream/master'
6c6d8a2 
* upstream/master: (22 commits)
  Fix printing of complex and logarithmic quantities (PainterQubits#366)
  Remove @_doctables (PainterQubits#363)
  Fix a doctest (PainterQubits#365)
  Release v1.3.0
  Add page headers to documentation (PainterQubits#361)
  Fix link to documentation in README.md: latest -> dev. (PainterQubits#360)
  Properly document Quantity constructor (PainterQubits#357)
  Delete show(::IO, ::Type) methods. Closes PainterQubits#321 (PainterQubits#322)
  Throw error for div etc. with affine quantities (PainterQubits#354)
  Fixes for the documentation (PainterQubits#356)
  Enable Travis on macOS (PainterQubits#355)
  Switch to a more standard Documenter setup (PainterQubits#353)
  Update repo URL (PainterQubits#352)
  Delete duplicate @affineunit docstring in the documentation (PainterQubits#349)
  Fix some doctests (PainterQubits#345)
  Add AbstractQuantity docstring to docs (PainterQubits#351)
  Provide Base.isless() for LogScaled values (PainterQubits#315)
  Small fixes to documentation (PainterQubits#341)
  Add CompatHelper, reduce frequency of TagBot to once per day (PainterQubits#337)
  Fix conversion of fractional units (PainterQubits#335)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sostock @codecov-commenter @ajkeller34