Fix conversion of fractional units #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 80.23% 80.32% +0.08%
==========================================
Files 15 15
Lines 1174 1174
==========================================
+ Hits 942 943 +1
+ Misses 232 231 -1
Continue to review full report at Codecov.
|
|
@ajkeller34 could you check this? BTW, I think these comments in line 14–15 that say: # fact1 is what would need to be multiplied to get to base SI units
# fact2 is what would be multiplied to get from the result to base SI unitsshould be updated to refer to |
giordano
approved these changes
May 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
- Coverage 80.23% 79.72% -0.52%
==========================================
Files 15 15
Lines 1174 1174
==========================================
- Hits 942 936 -6
- Misses 232 238 +6
Continue to review full report at Codecov.
|
briochemc
added a commit
to briochemc/Unitful.jl
that referenced
this pull request
Aug 10, 2020
* upstream/master: (22 commits) Fix printing of complex and logarithmic quantities (PainterQubits#366) Remove @_doctables (PainterQubits#363) Fix a doctest (PainterQubits#365) Release v1.3.0 Add page headers to documentation (PainterQubits#361) Fix link to documentation in README.md: latest -> dev. (PainterQubits#360) Properly document Quantity constructor (PainterQubits#357) Delete show(::IO, ::Type) methods. Closes PainterQubits#321 (PainterQubits#322) Throw error for div etc. with affine quantities (PainterQubits#354) Fixes for the documentation (PainterQubits#356) Enable Travis on macOS (PainterQubits#355) Switch to a more standard Documenter setup (PainterQubits#353) Update repo URL (PainterQubits#352) Delete duplicate @affineunit docstring in the documentation (PainterQubits#349) Fix some doctests (PainterQubits#345) Add AbstractQuantity docstring to docs (PainterQubits#351) Provide Base.isless() for LogScaled values (PainterQubits#315) Small fixes to documentation (PainterQubits#341) Add CompatHelper, reduce frequency of TagBot to once per day (PainterQubits#337) Fix conversion of fractional units (PainterQubits#335) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #327