Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update and fix ResNet cn docs #4322

Merged
merged 11 commits into from
Jun 16, 2022
Merged

update and fix ResNet cn docs #4322

merged 11 commits into from
Jun 16, 2022

Conversation

SigureMo
Copy link
Member

@SigureMo SigureMo commented Mar 19, 2022 •
edited
Loading

文档更新工作

PaddlePaddle/Paddle#40588 的中文文档 PR

文档修复工作

并做了一系列文档修复工作（仅 ResNet 系列，其他的模型在其余 PR 修）～

其它待一并修复的

总结以上 issue 所存在的问题

正在一一进行修改

英文文档 PR

PaddlePaddle/Paddle#43523

PADDLEPADDLE_PR=43523

相关 issue

closes PaddlePaddle/Paddle#43112
closes #4796
closes #4241
closes #4241
closes #4888
closes #4887
closes #4767
closes #4763
closes #4707

其它

Note

由于涉及 2.3.0-rc0 时期的 API 修改，可能需要 cherry-pick 到 2.3

另外，本 PR 主要验证一些修改方式是否合适，其他的模型将在修改方式确定后再另提 PR 一并修改

@paddle-bot-old
Copy link

Thanks for your contribution!

@SigureMo SigureMo mentioned this pull request Mar 19, 2022
Merged
RichardWooSJTU pushed a commit to RichardWooSJTU/docs that referenced this pull request Apr 8, 2022
@jerrywgz
[MOT] add FairMot c++ deploy (PaddlePaddle#4322)
d896574 
* add fairmot deploy

* separate main_jde

* update copyright & add PrintBenchmark

* refine lap
@SigureMo SigureMo force-pushed the re-impl-resnext-based-on-resnet-cn-docs branch from 3e11a73 to 0e6223a Compare April 22, 2022 09:56
@SigureMo
Copy link
Member Author

文档预览构建完成，请点击查看: http://preview-pr-4322.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html

这个棒诶！不过怎么是 Oops……构建后才能正常显示嘛？

@TCChenlong
Copy link
Collaborator

这个目前要CI通过才可以，因为示例代码没跑过，所以挂掉了，可以这样试试：https://github.com/PaddlePaddle/docs/wiki/%5BBeta%5D%E9%A3%9E%E6%A1%A8%E6%96%87%E6%A1%A3%E9%A2%84%E8%A7%88%E5%B7%A5%E5%85%B7#%E4%B8%89%E9%80%9A%E8%BF%87-docs-%E4%B8%80%E8%B5%B7%E6%9E%84%E5%BB%BA-paddle-%E7%9A%84%E9%A2%84%E8%A7%88

@SigureMo
Copy link
Member Author

好的我试下～

@SigureMo SigureMo closed this Apr 24, 2022
@SigureMo SigureMo reopened this Apr 24, 2022
@SigureMo
Copy link
Member Author

SigureMo commented Apr 27, 2022 •
edited
Loading

@TCChenlong

image

image

image

看起来是 need_check_files 里包含了已经删除的文件 ResNeXt_cn.rst 文件，因此之后 check_api_parameters 时候找不到该文件，这要怎么办呀？是说不能删除文件嘛？可是 PaddlePaddle/Paddle#40588 确实删除了该 API 呀～

@Liyulingyue Liyulingyue mentioned this pull request Apr 29, 2022
Closed
@SigureMo SigureMo mentioned this pull request May 21, 2022
Closed
@SigureMo SigureMo mentioned this pull request Jun 1, 2022
Closed
@SigureMo SigureMo force-pushed the re-impl-resnext-based-on-resnet-cn-docs branch from 25c4413 to f84afe8 Compare June 1, 2022 15:04
@SigureMo
Copy link
Member Author

SigureMo commented Jun 1, 2022

@TCChenlong 之前的问题好像消失了，貌似只需要 approve 就可以 merge 啦～

感觉拖了好久了 2333，今天看到 PaddlePaddle/Paddle#43112 才又想起来 😂

@SigureMo SigureMo changed the title cn docs for reimplement ResNeXt [WIP, Don't merge] cn docs for reimplement ResNeXt Jun 14, 2022
@SigureMo SigureMo force-pushed the re-impl-resnext-based-on-resnet-cn-docs branch from 1b19db8 to bd10c9f Compare June 14, 2022 15:05
@SigureMo SigureMo mentioned this pull request Jun 14, 2022
Merged
@SigureMo SigureMo changed the title [WIP, Don't merge] cn docs for reimplement ResNeXt update and fix ResNet docs Jun 14, 2022
@SigureMo SigureMo changed the title update and fix ResNet docs update and fix ResNet cn docs Jun 14, 2022
@SigureMo
Copy link
Member Author

龙哥召唤术！ @TCChenlong

我又顺便做了下这些文件相关的文档修复（详情见最上面～），不过英文文档自动生成 forward 函数的问题我无法解决……

@SigureMo
Copy link
Member Author

@Liyulingyue 哦对，还得让你给我第一个 review 呢 [doge]

@Liyulingyue
Copy link
Contributor

@Liyulingyue 哦对，还得让你给我第一个 review 呢 [doge]

粗略看了一眼，感觉没啥毛病哈哈哈哈

Ligoml
Ligoml approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ligoml Ligoml merged commit d209218 into PaddlePaddle:develop Jun 16, 2022
@SigureMo SigureMo deleted the re-impl-resnext-based-on-resnet-cn-docs branch June 16, 2022 08:09
SigureMo added a commit to cattidea/paddle-docs that referenced this pull request Jun 16, 2022
@SigureMo
update and fix ResNet cn docs (PaddlePaddle#4322)
db134a6 
* refine cn docs

* width_per_group -> width

* remove ResNeXt from Overview

* trigger

* copy from en docs

* add a blank line

* trigger ci (remove PADDLEPADDLE_PR)

* refine `Returns`

* add space between cn and en char

* refine desc of pretrained

* fix wrong ref
This was referenced Jun 16, 2022
Merged
Merged
TCChenlong pushed a commit that referenced this pull request Jun 17, 2022
@SigureMo
[Cherry pick] ResNeXt related release note and docs (#4934)
1bf0b38 
* fix and update 2.3.0 release note (#4899)

* fix typos: CRS -> CSR

* remove ResNeXt class API from 2.3.0 release note

* update and fix ResNet cn docs (#4322)

* refine cn docs

* width_per_group -> width

* remove ResNeXt from Overview

* trigger

* copy from en docs

* add a blank line

* trigger ci (remove PADDLEPADDLE_PR)

* refine `Returns`

* add space between cn and en char

* refine desc of pretrained

* fix wrong ref

* fmt code
@SigureMo SigureMo mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ligoml Ligoml Ligoml approved these changes

Assignees
No one assigned
Labels
contributor status: not progressed
Projects
None yet
Milestone
No milestone
4 participants
@SigureMo @TCChenlong @Liyulingyue @Ligoml