Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.68】为神经网络编译器 CINN 增加 argmax 和 argmin 算子 #192

Merged
merged 7 commits into from
Aug 10, 2022
Merged

【Hackathon No.68】为神经网络编译器 CINN 增加 argmax 和 argmin 算子 #192

merged 7 commits into from
Aug 10, 2022

Conversation

zrr1999
Copy link
Member

@zrr1999 zrr1999 commented Jul 29, 2022

No description provided.

@paddle-bot
Copy link

paddle-bot bot commented Jul 29, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@zrr1999 zrr1999 mentioned this pull request Jul 29, 2022
Closed
zhhsplendid
zhhsplendid reviewed Aug 4, 2022
View reviewed changes
rfcs/CINN/APIs/20220729_api_design_for_argmin_and_argmax.md Outdated Show resolved Hide resolved
rfcs/CINN/APIs/20220729_api_design_for_argmin_and_argmax.md Outdated Show resolved Hide resolved
rfcs/CINN/APIs/20220729_api_design_for_argmin_and_argmax.md Outdated Show resolved Hide resolved
rfcs/CINN/APIs/20220729_api_design_for_argmin_and_argmax.md Outdated Show resolved Hide resolved
rfcs/CINN/APIs/20220729_api_design_for_argmin_and_argmax.md Outdated Show resolved Hide resolved
rfcs/CINN/APIs/20220729_api_design_for_argmin_and_argmax.md Show resolved Hide resolved
rfcs/CINN/APIs/20220729_api_design_for_argmin_and_argmax.md

# 附件及参考资料

[CINN文档](https://paddlepaddle.github.io/CINN/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

也可以放一些你参考xla、tvm的代码的github链接（比如链接到相应代码行的网址），未来人对照看，就很方便。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的已经添加了新的文档链接

zhhsplendid
zhhsplendid previously approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

设计文档我没有什么问题了，关于我的最后一条评论，你看看参考文档要更新吗？更新整个文档更完整。不更新对主体设计文档影响也不大。

@zrr1999
Copy link
Member Author

zrr1999 commented Aug 10, 2022

设计文档我没有什么问题了，关于我的最后一条评论，你看看参考文档要更新吗？更新整个文档更完整。不更新对主体设计文档影响也不大。

好的，已经添加了新的文档链接

zhhsplendid
zhhsplendid approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很好！我完全没有问题了，我来合并本设计文档吧

@zhhsplendid zhhsplendid merged commit 9a5a9fd into PaddlePaddle:master Aug 10, 2022
@zrr1999 zrr1999 mentioned this pull request Aug 19, 2022
Open
@zrr1999 zrr1999 mentioned this pull request Sep 18, 2022
Merged
@zrr1999 zrr1999 deleted the argmax branch September 18, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

Assignees

@luotao1 luotao1

@zhhsplendid zhhsplendid

@Ligoml Ligoml

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zrr1999 @zhhsplendid @luotao1 @Ligoml