This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 115
【PaddlePaddle Hackathon 68】add argmax and argmin op #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cinn/frontend/net_builder.h # cinn/hlir/op/contrib/CMakeLists.txt # cinn/hlir/op/use_ops.h # cinn/pybind/frontend.cc
This was referenced Sep 18, 2022
haozech
reviewed
Sep 21, 2022
haozech
reviewed
Sep 21, 2022
haozech
reviewed
Sep 21, 2022
# Conflicts: # cinn/frontend/net_builder.h
haozech
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rfc:PaddlePaddle/community#192
本pr利用argsort实现了argmax和argmin算子,同时修复了argsort的一个bug
在原本的argsort中,返回的结果是某个位置的大小排序,但按照最初的rfc,返回的应该是按照从大到小排序后的返回索引值例子如下。
错误的argsort
期望的argsort