Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th Fundable Projects 3 No.71】fluid operator correlation #63765

Closed
wants to merge 1 commit into from

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Apr 22, 2024

PR Category

Others

PR Types

Others

Description

迁移 correlation

Copy link

paddle-bot bot commented Apr 22, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个最好写个简单的单测进行测试。尤其是测试通过sig.cc调用kernel的情况。

@co63oc
Copy link
Contributor Author

co63oc commented Apr 25, 2024

这个最好写个简单的单测进行测试。尤其是测试通过sig.cc调用kernel的情况。

已经测试过,不添加 paddle/fluid/operators/ops_signature/correlation_sig.cc 提示错误算子没有注册,现在python api中使用legacy调用需要使用sig.cc,以后不使用legacy调用时应该不用sig.cc
已有单测文件是 test/contrib/test_correlation.py

@co63oc
Copy link
Contributor Author

co63oc commented Apr 26, 2024

合入 #63772

@co63oc co63oc closed this Apr 26, 2024
@co63oc co63oc deleted the fix_correlation branch May 11, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants