Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 6th Fundable Projects 3 No.306、71、265、268】fluid operator requantize #63772

Merged
merged 6 commits into from
May 10, 2024

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Apr 23, 2024

PR Category

Others

PR Types

Others

Description

迁移算子
requantize
partial_sum
partial_concat
correlation

Copy link

paddle-bot bot commented Apr 23, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Apr 23, 2024
@co63oc co63oc force-pushed the fix_requantize branch 2 times, most recently from 7d97504 to 00bdcc2 Compare April 26, 2024 01:51
@co63oc
Copy link
Contributor Author

co63oc commented Apr 28, 2024

已修改partial_sum, correlation增加yaml

@co63oc
Copy link
Contributor Author

co63oc commented Apr 28, 2024

@YuanRisheng 已修改CI完成

YuanRisheng
YuanRisheng previously approved these changes Apr 28, 2024
wanghuancoder
wanghuancoder previously approved these changes May 7, 2024
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 141 to 143
void CorrelationInferMeta(const MetaTensor& input1,
const MetaTensor& input2,
int pad_size,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个属于binary类型函数,需要放到binary.h/cc中

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@luotao1
Copy link
Contributor

luotao1 commented May 9, 2024

需要过一下Coverage流水线

@luotao1 luotao1 merged commit dbe5913 into PaddlePaddle:develop May 10, 2024
31 checks passed
@co63oc co63oc changed the title 【Hackathon 6th Fundable Projects 3 No.306】fluid operator requantize 【Hackathon 6th Fundable Projects 3 No.306、71、265、268】fluid operator requantize May 11, 2024
co63oc added a commit to co63oc/Paddle that referenced this pull request May 11, 2024
@co63oc co63oc deleted the fix_requantize branch May 11, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants