Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commander: small clean up: Manual-->Stabilized rename, COM_POSCTL_NAVL better description #23544

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

sfuhrer
Copy link
Contributor

@sfuhrer sfuhrer commented Aug 14, 2024

Small clean up in Commander:

  • make clear that with "Manual" we actually mean "Stabilized" flight mode (which are only the same thing for Hovering vehicles)
  • improve description of COM_POSCTL_NAVL
  • only have one decimal value for COM_FAIL_ACT_T, that should be enough and improves the readability of the param.

@hamishwillee
Copy link
Contributor

@sfuhrer Should we more generally clean up docs https://docs.px4.io/main/en/flight_modes_mc/manual_stabilized.html so that this is called "Stabilized mode" to match FW https://docs.px4.io/main/en/flight_modes_fw/stabilized.html ?

@sfuhrer
Copy link
Contributor Author

sfuhrer commented Aug 21, 2024

@sfuhrer Should we more generally clean up docs https://docs.px4.io/main/en/flight_modes_mc/manual_stabilized.html so that this is called "Stabilized mode" to match FW https://docs.px4.io/main/en/flight_modes_fw/stabilized.html ?

Yes indeed, I would call it Stabilized and only have an info box saying that "Manual" is mapped to "Stabilized" for hovering vehicles.

@hamishwillee
Copy link
Contributor

@sfuhrer Should we more generally clean up docs https://docs.px4.io/main/en/flight_modes_mc/manual_stabilized.html so that this is called "Stabilized mode" to match FW https://docs.px4.io/main/en/flight_modes_fw/stabilized.html ?

Yes indeed, I would call it Stabilized and only have an info box saying that "Manual" is mapped to "Stabilized" for hovering vehicles.

Great. Fixed in PX4/PX4-user_guide#3356

@bresch bresch merged commit c86d44f into main Aug 29, 2024
95 checks passed
@bresch bresch deleted the pr-commander-small-param-imporvements-main branch August 29, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants