-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getting started tutorial #43
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,8 @@ using Printf, CairoMakie # for I/O and plotting | |
In this introductory tutorial, we will use the CPU backend for simplicity: | ||
|
||
```julia | ||
arch = Arch(CPU()) | ||
backend = CPU() | ||
arch = Arch(backend) | ||
``` | ||
|
||
If a different backend is desired, one needs to load the relevant package accordingly. For example, if Nvidia or AMD GPUs are available, one can comment out `using CUDA` or `using AMDGPU` and make sure to use `arch = Arch(CUDABackend())` or `arch = Arch(ROCBackend())`, respectively, when selecting the architecture. For further information about executing on a single-device or multi-device architecture, see the documentation section for [Architectures](./concepts/architectures.md) | ||
|
@@ -128,6 +129,20 @@ set!(C, grid, (_, _) -> rand()) | |
bc!(arch, grid, C => Neumann(); exchange=C) | ||
``` | ||
|
||
You should get a result like in the following plot. | ||
|
||
```julia | ||
fig = Figure() | ||
ax = Axis(fig[1, 1]; | ||
aspect = DataAspect(), | ||
xlabel = "x", ylabel = "y", | ||
title = "it = 0") | ||
plt = heatmap!(ax, centers(grid)..., interior(C) |> Array; | ||
colormap = :turbo) | ||
Colorbar(fig[1, 2], plt) | ||
display(fig) | ||
``` | ||
Comment on lines
+132
to
+144
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was no code to show how to plot this stuff for reference. |
||
|
||
```@raw html | ||
<div style="text-align: center;"> | ||
<img src="https://raw.githubusercontent.com/PTsolvers/Chmy.jl/main/docs/src/assets/field_set_ic_random.png" width="50%"/> | ||
|
@@ -150,6 +165,18 @@ end | |
|
||
After running the simulation, you should see something like this, here the final result at `it = 100` for the field `C` is plotted: | ||
|
||
```julia | ||
fig = Figure() | ||
ax = Axis(fig[1, 1]; | ||
aspect = DataAspect(), | ||
xlabel = "x", ylabel = "y", | ||
title = "it = 100") | ||
plt = heatmap!(ax, centers(grid)..., interior(C) |> Array; | ||
colormap = :turbo) | ||
Colorbar(fig[1, 2], plt) | ||
display(fig) | ||
``` | ||
|
||
```@raw html | ||
<div style="text-align: center;"> | ||
<img src="https://raw.githubusercontent.com/PTsolvers/Chmy.jl/main/docs/src/assets/diffusion_2d_it_100.png" width="50%"/> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the main bug that made some code down below throw an error.