Fix getting started tutorial #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranocha
commented
Sep 13, 2024
Comment on lines
-55
to
+56
| arch = Arch(CPU()) | ||
| backend = CPU() | ||
| arch = Arch(backend) |
There was a problem hiding this comment.
This was the main bug that made some code down below throw an error.
Comment on lines
+132
to
+144
| You should get a result like in the following plot. | ||
|
|
||
| ```julia | ||
| fig = Figure() | ||
| ax = Axis(fig[1, 1]; | ||
| aspect = DataAspect(), | ||
| xlabel = "x", ylabel = "y", | ||
| title = "it = 0") | ||
| plt = heatmap!(ax, centers(grid)..., interior(C) |> Array; | ||
| colormap = :turbo) | ||
| Colorbar(fig[1, 2], plt) | ||
| display(fig) | ||
| ``` |
There was a problem hiding this comment.
There was no code to show how to plot this stuff for reference.
|
Thanks for suggesting this. I believe @utkinis could check and merge. |
|
Thanks for the fix. Yeah, the old version of the code had more doc-specific features like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at the docs and wanted to follow the tutorial. While doing so, I noticed that it didn't work completely. Thus, I have updated the code accordingly.
Of course, the better solution would be to run this while generating the docs, but I didn't want to do this right now.