Support boot in hostlink without starting the cores. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coralmw
requested changes
Aug 26, 2021
hostlink/HostLink.h
Outdated
Comment on lines
136
to
137
| void boot(const char* codeFilename, const char* dataFilename); | ||
| void boot(const char* codeFilename, const char* dataFilename, | ||
| bool start=true); |
There was a problem hiding this comment.
Pure pedantry, but could this be nicer by adding loadAll(), to load a instr binary onto everything, and rewriting boot to boot(...) { loadAll(...); start() }?
Using a method called boot as a broadcast write feels confusing! Otherwise LGTM.
There was a problem hiding this comment.
Quite right, addressed in e11a4d9.
|
Thanks both. @mvousden I think you wrote |
coralmw
pushed a commit
that referenced
this pull request
Apr 26, 2022
Support boot in hostlink without starting the cores.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to support efficient loading of cores (without reading the same file multiple times), in order to support hardware idle detection by the Orchestrator (see also POETSII/Orchestrator#242).