Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ Website: [phpixie.com](https://phpixie.com/)

PHPixie started as a micro framework and has gradually grown to be one of the
most popular fullstack PHP frameworks while retaining its high performance.
This is in part because of the strict architecture that avoids common pitfalls
such as reliance on static methods, global scope, singletons and other antipatterns,
thus also ensuring that the code is easy to read, debug, extend and test.
In fact, all PHPixie components boast full unit test coverage. This PHP framework
never stands in your way and provides you with full control over execution
flow. It's easy to learn and straightforward to master.

But it's not all just about the code. The PHPixie community is very friendly and
helpful—you can expect an answer to your question within minutes of asking
it in the chat. The framework documentation is full of examples and is regularly
updated with tutorial videos.
The reason PHPixie will be one of the most popular full stack PHP frameworks
is that the strict architecture that avoids common pitfalls such as reliance on
static methods, global scope, singletons and other antipatterns, and ensures that
Copy link

@garrettw garrettw Apr 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence's grammar is still wrong. The best correction here would probably be removing the second "that" on line 11 as well as the comma after "antipatterns".
However, you've inserted a new meaning on line 10 saying that PHPixie will be popular -- you cannot know that it will be. Plus, there are so many factors that determine what frameworks are popular; saying this (on line 10) sounds a bit naïve.

the code is easy to read, debug, extend and test. In fact, all PHPixie components
boast full unit test coverage. PHPixie never stands in your way and provides you with
full control over execution flow; therefore, PHPixie is easy to learn and straightforward
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this period to "; therefore," completely changes the meaning here. It links the two thoughts together in a way that most likely was not intended originally. Also, it's redundant to say "PHPixie" twice in a row.

to master.

But, PHPixie is not all just about the code. PHPixie has a friendly and helpful community
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"But" should not be followed by a comma.

so that you can expect an answer to your question within minutes of asking it in the chat.
The framework documentation is full of examples and is regularly updated with tutorial videos.

## Demo
Want to see an example? Check out a simple base project implementing user and administrator authorization: https://github.com/phpixie/project-auth
Expand Down