Update README.md #46
Update README.md #46
Conversation
Here is a new revision! Sorry for the mistakes!
| updated with tutorial videos. | ||
| The reason PHPixie will be one of the most popular full stack PHP frameworks | ||
| is that the strict architecture that avoids common pitfalls such as reliance on | ||
| static methods, global scope, singletons and other antipatterns, and ensures that |
There was a problem hiding this comment.
This sentence's grammar is still wrong. The best correction here would probably be removing the second "that" on line 11 as well as the comma after "antipatterns".
However, you've inserted a new meaning on line 10 saying that PHPixie will be popular -- you cannot know that it will be. Plus, there are so many factors that determine what frameworks are popular; saying this (on line 10) sounds a bit naïve.
| static methods, global scope, singletons and other antipatterns, and ensures that | ||
| the code is easy to read, debug, extend and test. In fact, all PHPixie components | ||
| boast full unit test coverage. PHPixie never stands in your way and provides you with | ||
| full control over execution flow; therefore, PHPixie is easy to learn and straightforward |
There was a problem hiding this comment.
Changing this period to "; therefore," completely changes the meaning here. It links the two thoughts together in a way that most likely was not intended originally. Also, it's redundant to say "PHPixie" twice in a row.
| full control over execution flow; therefore, PHPixie is easy to learn and straightforward | ||
| to master. | ||
|
|
||
| But, PHPixie is not all just about the code. PHPixie has a friendly and helpful community |
There was a problem hiding this comment.
"But" should not be followed by a comma.
|
As I said on your other pull request (PR), all you have to do to submit changes is make another commit on your branch. Making a completely new PR is not necessary and causes confusion, so please close your previous PR #45. Furthermore, I think it would serve you better to (1) study English grammar a bit more before submitting documentation changes, and (2) pick a project that needs more work done than this one. This file really didn't need any changes to begin with. |
Here is a new revision! Sorry for the mistakes I had made in last request!