Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 687 - fix for Coordinate in columnIndexFromString with new test cases #718

Closed
wants to merge 2 commits into from

Conversation

yudina-m
Copy link

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

For the correct work of the \PhpOffice\PhpSpreadsheet\Cell\Coordinate::columnIndexFromString
Issue #687

Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Unfortunately I don't think it can be merged. First columnIndexFromString is very performance sensitive and extra validation via regexp is probably not a great idea performance wise. Second stripping the '$' in the reader seems a bit out of context.

Instead of those changes, I think \PhpOffice\PhpSpreadsheet\Cell\Coordinate::rangeBoundaries() only should be changed to strip '$' before using columnIndexFromString (and of courses unit tests should be adapted to reflect that)

@stale
Copy link

stale bot commented Dec 20, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants