Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #687: strip $ when converting a string to a coordinate #1345

Closed
wants to merge 1 commit into from

Conversation

AlexeyKosov
Copy link

This is:

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Fixes #687

@AlexeyKosov AlexeyKosov requested a review from PowerKiKi February 3, 2020 14:04
Copy link
Member

@PowerKiKi PowerKiKi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR checklist must be completed in order for this PR to be merged.

@PowerKiKi
Copy link
Member

Also I see not explanation why you chose to edit columnIndexFromString instead of rangeBoundaries as I mentioned there.

@danatemple
Copy link

@PowerKiKi I have tried to strip the $ in rangeBoundaries for my instance of hitting #687, it does not solve the problem in that case. @AlexeyKosov solution solves the problem however.

@stale
Copy link

stale bot commented Apr 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Apr 23, 2020
@PowerKiKi
Copy link
Member

Fixed in #1326

@PowerKiKi PowerKiKi closed this Apr 26, 2020
@oleibman oleibman removed the stale label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Undefined index $ : while importing excel file
4 participants