Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xlsx Reader Default Cell Type #4139

Merged
merged 4 commits into from
Aug 24, 2024
Merged

Xlsx Reader Default Cell Type #4139

merged 4 commits into from
Aug 24, 2024

Commits on Aug 13, 2024

  1. Xlsx Reader Default Cell Type

    Suggested by PR PHPOffice#1321 from @rtek, which was marked stale in March 2020. If the xml for a cell does not specify a type, PhpSpreadsheet has been using string; however, Excel uses numeric. PhpSpreadsheet will be changed to do the same as Excel. In theory, this is a BC break; in practice, it is doubtful that anyone will be adversely affected. No changes in the existing unit tests were required. The new test from rtek does demonstrate the change in behavior; however, the new behavior is certainly what a user would expect to happen. Unlike the original PR, this one is restricted to Xlsx Reader; I do not believe that any logic change is needed for Writer. (N.B. - changing Writer to use class constants rather than literals is a good idea, but, with no other logic change in this version, it seems risky - I may do that as separate PR.)
    oleibman committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a377f44 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    958c8c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Update CHANGELOG.md

    oleibman authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    aecb0b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    47ee4da View commit details
    Browse the repository at this point in the history