[BC break/RFC] Fix default cell type treatment as numeric for XLSX #1321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpreadsheetML defines cell type attribute t to indicate the cell type.
The attribute is optional and defaults to "n" for numeric. The XLSX
Reader incorrectly defaults the cell type to "stringy" for both
undefined t attribute and t="n".
This is:
Checklist:
Why this change is needed?
SpreadsheetML defines the default cell type as numeric, but the XLSX reader treats a missing cell type or cell type = numeric as a "stringy" value. This means that the reader is discarding the numeric type information from the XML. In most cases this is masked by the
DefaultBinder
which explicitly preg's for numeric strings and correct the reader's behavior.The bugs / inconsistencies are:
IValueBinder
is always presented with string, even when the XML defines the type as numericThis is probably a BC break as it seems like a fundamental issue with the Reader - I would expect there is lots of code relying on numeric strings being casted to a number despite the XML declaring them as strings.