-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS var: stepped process #1281
CSS var: stepped process #1281
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On hold until there's an answer for the second comment
86cb1bb
to
594c08d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't finished the technical review (CSS vars) but here are some first feedback.
I think the result observed in this PR is better but is it normal that the visible focus has changed? Not at all breakpoints but the shape is sometimes different (smaller).
3f6f1e0
to
7ca6204
Compare
7ca6204
to
08122d8
Compare
@louismaximepiton Reverted the creation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Visible focus has changed but will be revisited via #1189.
CSS var for stepped process