Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-sass workflow in v5 #36478

Closed
2 tasks done
louismaximepiton opened this issue Jun 1, 2022 · 4 comments
Closed
2 tasks done

node-sass workflow in v5 #36478

louismaximepiton opened this issue Jun 1, 2022 · 4 comments
Labels

Comments

@louismaximepiton
Copy link
Member

louismaximepiton commented Jun 1, 2022

Prerequisites

Proposal

Remove the node-sass workflow in v5.

Motivation and context

Here are my two motivations:

  • According to the documentation, node-sass is deprecated in Bootstrap v5. Is there any reason to keep it ? Is that a check for the retro-compatibility of this library ?
  • The second motivation needs a bit more context. I'm trying to build a component that needs to concatenate strings inside a CSS variable (something that could happen in Bootstrap). The first issue here comes from the way that Sass compiles its variables inside a #{}, Sass unquotes strings inside. A workaround exists : @use "sass:meta". However, node-sass doesn't compile @use and so the CI fails as you can see here (We are using the same CI as Bootstrap).

I'm open to any thoughts.

@julien-deramond
Copy link
Member

/CC @XhmikosR

@ffoodd
Copy link
Member

ffoodd commented Jun 1, 2022

V5 does not fully handle Dart Sass, trying only to stay compatible with both compilers.

In your case, you may use the inspect() Sass function, which existed before Dart Sass and is already used through Bootstrap and Boosted, if I recall correctly.

@XhmikosR
Copy link
Member

XhmikosR commented Jun 1, 2022

Yeah, what @ffoodd said above. 👍

@XhmikosR XhmikosR closed this as completed Jun 1, 2022
@louismaximepiton
Copy link
Member Author

Thanks for the quick answer and for the explanation. Didn't know about this function. thanks a lot 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants