Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social buttons improvements #189

Closed
3 of 4 tasks
ffoodd opened this issue Jul 11, 2019 · 1 comment
Closed
3 of 4 tasks

Social buttons improvements #189

ffoodd opened this issue Jul 11, 2019 · 1 comment
Labels

Comments

@ffoodd
Copy link
Contributor

ffoodd commented Jul 11, 2019

There are tons of duplicated code in here, where it could be avoided:

  • define a parent class (like .btn-social) to prevent duplicated code:
.btn-* {
  height: 2.5rem;
  background-repeat: no-repeat;
  &:hover,
  &:focus {
    outline: none;
  }
}

is duplicated 10 times!!

  • Use em isntead of rem to set the height would allow social buttons to respect size variants, since height would be related to font-size
  • inlined SVGs could be improved, related to Icon system using SVG  #182
  • there has to be better way than setting inlined SVGs for each state… This is extremely verbose (thus resulting in a much, much bigger file) when we only want to change a few colors… Whether we support IE11 or drop it, we could simplify the code by using mask-image instead of background-image.

To reboot!

@ffoodd
Copy link
Contributor Author

ffoodd commented Oct 7, 2019

Last item will be treated separately, along with #182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants