Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon system using SVG #182

Open
6 tasks
ffoodd opened this issue Jun 19, 2019 · 11 comments
Open
6 tasks

Icon system using SVG #182

ffoodd opened this issue Jun 19, 2019 · 11 comments

Comments

@ffoodd
Copy link
Contributor

ffoodd commented Jun 19, 2019

  • Get icons from Solaris REST API endpoint
  • Run SVGO
  • Build SVG sprite
  • Generate docs for Solaris:
  • document usage: mention IcoMoon for custom sprite
  • find our way for embedded icons (close, alerts, buttons and forms, social networks, carousel, burger…).

There's tons of resources below.

@ffoodd

This comment has been minimized.

@ffoodd
Copy link
Contributor Author

ffoodd commented Sep 18, 2019

And FWIW, the main goal of those inlined SVGs are to totally replace existing icon-font.

I guess inlined SVGs are not the best fit — will need some work, but SVG fragment identifiers are pretty decently supported.

Sara Soueidan wrote a post on 24ways and there's a good post and demo on Broken links.

Also if progressive enhancement is still a thing for Boosted, SVG sprite could be all black by default and enhanced using CSS masks to color it. This is done in sseeeedd, based on Noah Blon's post on CodePen.

@ffoodd ffoodd self-assigned this Sep 18, 2019
@ffoodd ffoodd changed the title Improve inlined SVG Icon system using SVG Sep 18, 2019
@ffoodd
Copy link
Contributor Author

ffoodd commented Oct 7, 2019

Another resource: https://ishadeed.com/article/using-svg-icons/

@ffoodd
Copy link
Contributor Author

ffoodd commented Nov 27, 2019

Well, that's a pretty good one: Bootstrap released their own icons system :

So I guess it's a good inspiration :D

And maybe should we have a dedicated Solaris Icons repository, based on this one…

@ffoodd ffoodd added the feature label Dec 4, 2019
@ffoodd ffoodd removed the v4 label Dec 16, 2019
@ffoodd ffoodd added this to the 5.0.0-alpha milestone Jan 16, 2020
@ffoodd

This comment has been minimized.

@ffoodd

This comment has been minimized.

@ffoodd

This comment has been minimized.

@ffoodd

This comment has been minimized.

@ffoodd
Copy link
Contributor Author

ffoodd commented Jun 5, 2020

The Solaris Icon system now has its own REST API endpoint. So I guess we can script something to get those icons, now :)

@ffoodd
Copy link
Contributor Author

ffoodd commented Dec 10, 2020

If we keep going with icon-font, Bootstrap Icons (PR #515) went with Fantasticon to generate them.

@ffoodd ffoodd removed their assignment Feb 26, 2021
@louismaximepiton louismaximepiton self-assigned this Oct 22, 2021
@philparry
Copy link

Interesting issue, which relates to anohter activity GDL is currently working on. We are migrating the solaris icons database into Master Media Digital Assets Management (DAM) platform. This platform is run by brand, and will make diffrent icon file formats more accessible via an API.

I suggest we link this project to this DAM activity - let'sdiscuss during an upcoming sprint planning meeting

@julien-deramond julien-deramond removed this from the 5.0.0 milestone Nov 12, 2021
@louismaximepiton louismaximepiton removed their assignment Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants