forked from rebuy-de/aws-nuke
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge rebuy-de/aws-nuke #6
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade to aws sdk version 1.28.12
* added eks fargate profile resource
* added eks nodegroup as resource
…ettings (rebuy-de#473) * fixed rrs behaviour on NS deletion
* Handle 101+ route53
…ction (rebuy-de#481) * rebuy-de#430 - cloudformation support for disabling termination protection
* Disable Security Hub See rebuy-de#452 Add the ability to detect regions with Security Hub enabled and disable it if a "hub" resource is returned. * Rename property of SecurityHub hub Arn
Replace the wildcard to ** to allow recurside sublevel directories in the nuke process. Co-authored-by: Bruno Paiuca <[email protected]>
Closed
marinatedpork
approved these changes
Mar 10, 2020
AmudaPalani
approved these changes
Mar 11, 2020
When can we expect this to get merged? |
nathanagood
approved these changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in rebuy-de/aws-nuke (upstream) for latest changes.