Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream #5

Closed
wants to merge 12 commits into from
Closed

Sync with upstream #5

wants to merge 12 commits into from

Conversation

rwhelan
Copy link

@rwhelan rwhelan commented Mar 9, 2020

Per comment: Optum/dce#312

eschwartz and others added 12 commits February 6, 2020 14:04
* Upgrade to aws sdk version 1.28.12
* added eks fargate profile resource
* added eks nodegroup as resource
…ettings (#473)

* fixed rrs behaviour on NS deletion
)

* #430 - cloudformation support for disabling termination protection
* Disable Security Hub

See #452

Add the ability to detect regions with Security Hub enabled and disable it if a
"hub" resource is returned.

* Rename property of SecurityHub hub Arn
Replace the wildcard to ** to allow recurside sublevel directories in
the nuke process.

Co-authored-by: Bruno Paiuca <[email protected]>
@eschwartz
Copy link

image

Hey @rwhelan -- it looks like we aren't able to do a direct PR fro rebuy-de into Optum/aws-nuke.
Closing in favor of #6.

What I did for reference:

git remote add rebuy-de https://github.com/rebuy-de/aws-nuke.git
git checkout -b merge-upstream
git merge rebuy-de/master
git push

then opened a PR for merge-upstream

Thanks or getting this started!

@eschwartz eschwartz closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants