Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): raise error during analysis plate reader read without lid closed #16941

Merged

Conversation

CaseyBatten
Copy link
Contributor

@CaseyBatten CaseyBatten commented Nov 21, 2024

Overview

Covers RABR-674

Ensures that an error is raised during analysis when the lid is not closed and a read is attempted, and that the error goes away if the lid is closed.

Test Plan and Hands on Testing

  • Run the following Protocol, get an analysis error of type CannotPerformModuleAction
from opentrons.protocol_api import ProtocolContext
metadata = {
    "protocolName": "plate reader test for read without lid",
}

requirements = {"robotType": "Flex", "apiLevel": "2.21"}

def run(ctx: ProtocolContext) -> None:
    """Protocol."""
    plate_reader = ctx.load_module(
        "absorbanceReaderV1", "A3"
    )
    sample_plate = ctx.load_labware(
        "armadillo_96_wellplate_200ul_pcr_full_skirt", "D1", "Sample Plate 1"
    )
    plate_reader.close_lid()
    plate_reader.initialize("single", [450])
    plate_reader.open_lid()
    ctx.move_labware(sample_plate, plate_reader, use_gripper=True)
    result = plate_reader.read()

Changelog

Added new error to the engine command executor for the Read function of the plate reader.

Review requests

Risk assessment

Low

@CaseyBatten CaseyBatten requested a review from a team as a code owner November 21, 2024 20:13
@CaseyBatten CaseyBatten requested a review from ecormany November 21, 2024 20:15
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, and easy, thank you.

Copy link
Contributor

@rclarke0 rclarke0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested on my protocol and it raised the appropriate error.
image

@CaseyBatten CaseyBatten merged commit 8b2196a into chore_release-8.2.0 Nov 21, 2024
21 checks passed
@CaseyBatten CaseyBatten deleted the plate_reader_error_when_read_without_lid_close branch November 21, 2024 21:43
SyntaxColoring added a commit that referenced this pull request Nov 26, 2024
Conflicts:

api/src/opentrons/protocol_engine/commands/absorbance_reader/read.py:
Conflict in error message wording between PR #16941 in release and PR #16920 in edge. I took the one in release because the one in edge was an outdated cherry pick.

app/src/organisms/Desktop/Devices/ProtocolRun/ProtocolRunHeader/RunHeaderModalContainer/hooks/useRunHeaderDropTip.ts:
Just import statements.

app/src/organisms/DropTipWizardFlows/hooks/useTipAttachmentStatus/getPipettesWithTipAttached.ts:
Release removed `cursor: null` and `includeFixitCommands: null` from some network requests, leaving those fields unspecified instead (PR ##16893). Edge deleted this whole file in favor of a different one (PR #16904). I removed `cursor: null` from the new file; `includeFixitCommands: null` was already removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants