fix(app): Fix post run drop tip wizard always displaying after error recovery #16893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3614
Overview
We recently updated post-run tip checking to get the last run command via
useCurrentRunCommands
with parametersSomething on the server (likely Pydantic) deserializes the cursor: 'null' string to 0, which causes unexpected behavior (ex, we always pop drop tip wizard post-run, which we don't always want to do).
412e29f - The
api-client
typing involving command queries requires supplying acursor: null
if none is specified, so to fix, we must change the types and then update all usages of the relevant queries.0cdec49 - This fixes some unexpected behavior on the desktop app in which the post run CTA sometimes appears while "run again" is cloning the run. The fix is just to clear tip status while the run is resetting (on click on the
ActionButton
).Test Plan and Hands on Testing
Changelog
Risk assessment
useActionButtonProperties.ts