refactor(app): Update dropTipInPlace command text
#16610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
requested review from
ncdiehl11
and removed request for
a team and
ncdiehl11
mjhuff
force-pushed
the
app_update-drop-tip-cmd-text
branch
from
5d543bc to
d9c64ca
Compare
ecormany
reviewed
Oct 28, 2024
sfoster1
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-182
Overview
This PR updates tip drop command text when trash is dropped into a waste container, increasing specificity. Unfortunately, the command metadata itself does not give any
locationwhen performing a drop tip, so the app must derive the location from looking at the most recent addressableArea command. Fortunately, this should never be a compute-heavy scan unless the protocol does something like "move to trash" followed by a ton of "dispense over trash" before dropping tips, which seems quite unlikely in practice. Regardless, this instance serves as an example of places in which we should reduce compute done on the app in the future.While the newly added tests demonstrate a need for broader utilities for testing command text, I think keeping them locally scoped to this one file is fine for now - as we refactor command text (and add more testing), we can generalize these testing utilities.
297f366 - Better namespacing for utilities.
760e728 - Self explanatory.
870271d - Self explanatory given the subsequent commit.
5d543bc - Add the util necessary to derive the location, update the actual command text, and add testing!
Flex
Before
After
OT-2
Before
After
Test Plan and Hands on Testing
Changelog
Risk assessment
low