refactor(app): tighten getAddressableAreaDisplayName iface

Opentrons · Oct 25, 2024 · 760e728 · 760e728
1 parent 297f366
commit 760e728
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/...mands/hooks/useCommandTextString/utils/commandText/getMoveToAddressableAreaCommandText.ts b/...mands/hooks/useCommandTextString/utils/commandText/getMoveToAddressableAreaCommandText.ts
@@ -10,7 +10,7 @@ export function getMoveToAddressableAreaCommandText({
 }: HandlesCommands<MoveToAddressableAreaRunTimeCommand>): string {
   const addressableAreaDisplayName =
     commandTextData != null
-      ? getAddressableAreaDisplayName(commandTextData, command.id, t)
+      ? getAddressableAreaDisplayName(commandTextData.commands, command.id, t)
       : null
 
   return t('move_to_addressable_area', {

diff --git a/...s/useCommandTextString/utils/commandText/getMoveToAddressableAreaForDropTipCommandText.ts b/...s/useCommandTextString/utils/commandText/getMoveToAddressableAreaForDropTipCommandText.ts
@@ -10,7 +10,7 @@ export function getMoveToAddressableAreaForDropTipCommandText({
 }: HandlesCommands<MoveToAddressableAreaForDropTipRunTimeCommand>): string {
   const addressableAreaDisplayName =
     commandTextData != null
-      ? getAddressableAreaDisplayName(commandTextData, command.id, t)
+      ? getAddressableAreaDisplayName(commandTextData.commands, command.id, t)
       : null
 
   return t('move_to_addressable_area_drop_tip', {

diff --git a/...ocal-resources/commands/hooks/useCommandTextString/utils/getAddressableAreaDisplayName.ts b/...ocal-resources/commands/hooks/useCommandTextString/utils/getAddressableAreaDisplayName.ts
@@ -1,17 +1,16 @@
 import type {
   AddressableAreaName,
   MoveToAddressableAreaParams,
+  RunTimeCommand,
 } from '@opentrons/shared-data'
 import type { TFunction } from 'i18next'
 
-import type { CommandTextData } from '/app/local-resources/commands'
-
 export function getAddressableAreaDisplayName(
-  commandTextData: CommandTextData,
+  commands: RunTimeCommand[] | undefined,
   commandId: string,
   t: TFunction
 ): string {
-  const addressableAreaCommand = (commandTextData?.commands ?? []).find(
+  const addressableAreaCommand = (commands ?? []).find(
     command => command.id === commandId
   )