Link solidity libraries #208
Conversation
For managing solidity lib link
spalladino
force-pushed
the
feature/link-solidity-libraries
branch
3 times, most recently
from
cc908e2
to
b5714ff
Compare
spalladino
force-pushed
the
feature/link-solidity-libraries
branch
from
b5714ff
to
762805a
Compare
|
@jcarpanelli please review the new commits! |
spalladino
added
status:to-review
| "networks": {}, | ||
| "schemaVersion": "2.0.1", | ||
| "updatedAt": "2018-10-12T10:51:50.530Z" | ||
| } |
There was a problem hiding this comment.
Is it necessary to publish these build files?
There was a problem hiding this comment.
Actual stdlibs libs evm packags have their build artifacts published, so these ones for testing should have them as well.
| @@ -1,6 +1,6 @@ | |||
| import Truffle from '../models/truffle/Truffle'; | |||
| import Session from '../models/network/Session' | |||
| import Contracts from 'zos-lib/lib/utils/Contracts'; | |||
| import { Contracts } from 'zos-lib'; | |||
| this._checkSolidityLibImplementationAddress(alias, address) | ||
| this._checkSolidityLibImplementationBytecode(alias, address, bytecode) | ||
| } | ||
| //TODO: implement missing remote solidity libs validation |
There was a problem hiding this comment.
can we move this to an issue?
|
|
||
| // Verifies if a bytecode represents a solidity library. | ||
| export function isSolidityLib(bytecode) { | ||
| return bytecode.match(/^0x73[A-Fa-f0-9]{40}3014/) |
There was a problem hiding this comment.
we should add a comment explaining why we assume that expected bytecode to be a lib
| await Promise.all(_.map(contracts, async ([contractClass, contractAlias]) => { | ||
| contractClass.link(libraries); | ||
| await project.setImplementation(contractClass, contractAlias); | ||
| })); |
There was a problem hiding this comment.
This code is not that clear, +1 to refactor it in a future
There was a problem hiding this comment.
Yup, it's on my technical debt workflowy section
| @@ -97,6 +97,7 @@ export default { | |||
| contract.setProvider(web3.currentProvider) | |||
| contract.defaults({ from: web3.eth.accounts[0], ... defaults }) | |||
| contract.synchronization_timeout = syncTimeout | |||
| contract.setNetwork('test') | |||
| // run('rm contracts/*.sol ||:') | ||
| // run('rm zos.* ||:') | ||
| // run('rm package.* ||:') | ||
| // }) |
There was a problem hiding this comment.
should we remove this after statement?
There was a problem hiding this comment.
No, I unfortunately forgot to uncomment it. It's no harm though.
Fixes #85
This is a first approach for linking solidity libs before deploying logic contracts.
Implemented so far:
zos.network.json)zos status ... --fetchcommand to compare implementations as both logic contracts and solidity libsStill have to:
zos status ... --fixcommand