Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

Libraries are not linked when running zos push #85

Closed
spalladino opened this issue Sep 10, 2018 · 1 comment · Fixed by #208
Closed

Libraries are not linked when running zos push #85

spalladino opened this issue Sep 10, 2018 · 1 comment · Fixed by #208
Assignees
Labels
kind:bug source:user-feedback Feedback provided by end-users
Milestone

Comments

@spalladino
Copy link
Contributor

It seems that a Solidity library is not being properly linked before the logic contract is pushed to the network.

We could either:
1- Deploy a copy of the library for each logic contract that uses it, which is the fastest way to fix this issue, though limits reusability
2- Have a single copy of the library being shared amongst all contracts, or even exposed as part of an on-chain library, which would require storing it in the contracts object and adding an extra flag to identify it as a linkable library instead of a contract

See #81 for more info

@spalladino
Copy link
Contributor Author

Related to OpenZeppelin/openzeppelin-labs#91

@facuspagnuolo facuspagnuolo added this to the Backlog milestone Sep 12, 2018
@spalladino spalladino added the source:user-feedback Feedback provided by end-users label Sep 12, 2018
@facuspagnuolo facuspagnuolo modified the milestones: Backlog, v2.0.0 Sep 13, 2018
@jbcarpanelli jbcarpanelli self-assigned this Sep 25, 2018
@spalladino spalladino self-assigned this Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind:bug source:user-feedback Feedback provided by end-users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants