Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about low public key exponent #5234

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Add warning about low public key exponent #5234

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9243c4
Add warning about public key exponent
Amxx Oct 1, 2024
316b6f0
Update contracts/utils/cryptography/RSA.sol
ernestognw Oct 1, 2024
7d49ed4
Update contracts/utils/cryptography/RSA.sol
Amxx Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions contracts/utils/cryptography/RSA.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,12 @@
* 2048 bits. If you use a smaller key, consider replacing it with a larger, more secure, one.
*
* WARNING: This verification algorithm doesn't prevent replayability. If called multiple times with the same
* digest, public key and (valid signature), it will return true every time. Consider including an onchain nonce or
* unique identifier in the message to prevent replay attacks.
* digest, public key and (valid signature), it will return true every time. Consider including an onchain nonce
* or unique identifier in the message to prevent replay attacks.
*
* WARNING: This verification algorithm support any exponent. NIST recommendation are to use `65537` (or higher).
* That is the default value used by many libraries, such as openssl. Developpers may choose to reject public keys

Check failure on line 43 in contracts/utils/cryptography/RSA.sol

View workflow job for this annotation

GitHub Actions / codespell 

Developpers ==> Developers
ernestognw marked this conversation as resolved.
Show resolved Hide resolved
* using a low exponent out of security concerns.
*
* @param digest the digest to verify
* @param s is a buffer containing the signature
Expand Down