Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning about low public key exponent #5234

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Add warning about low public key exponent #5234

merged 3 commits into from
Oct 1, 2024

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Oct 1, 2024

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@Amxx Amxx added documentation Inline comments, guides, and examples. ignore-changeset labels Oct 1, 2024
@Amxx Amxx added this to the 5.1-after-freeze milestone Oct 1, 2024
@Amxx Amxx requested review from ernestognw and cairoeth October 1, 2024 14:39
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7d49ed4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx changed the title Add warning about public key exponent Add warning about low public key exponent Oct 1, 2024
cairoeth
cairoeth approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cairoeth cairoeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ernestognw ernestognw merged commit 49cd645 into OpenZeppelin:master Oct 1, 2024
18 checks passed
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Oct 2, 2024
@Amxx @ernestognw
Add warning about low public key exponent (OpenZeppelin#5234)
e24c155 
Co-authored-by: Ernesto García <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
@Amxx Amxx deleted the audit_5_1/RSA_exponent_warning branch October 2, 2024 10:02
Amxx added a commit that referenced this pull request Oct 2, 2024
@Amxx @ernestognw
Add warning about low public key exponent (#5234)
fd29158 
Co-authored-by: Ernesto García <[email protected]>
Signed-off-by: Hadrien Croubois <[email protected]>
@OpenZeppelin OpenZeppelin deleted a comment from Morhef Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cairoeth cairoeth cairoeth approved these changes

@ernestognw ernestognw ernestognw approved these changes

Assignees
No one assigned
Labels
documentation Inline comments, guides, and examples. ignore-changeset
Projects
None yet
Milestone
5.1-after-freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@Amxx @ernestognw @cairoeth