Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove double declaration of P in P256 #5159

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Remove double declaration of P in P256 #5159

merged 1 commit into from
Aug 21, 2024

Conversation

cairoeth
Copy link
Contributor

Removes the double declaration of P in P256 to save some gas on _jAdd, isValidPublicKey, and _jDouble operations. Also helps give more room to avoid stack too deep issues, like for #5148.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

@cairoeth cairoeth requested review from Amxx and ernestognw August 21, 2024 19:27
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 26e5bbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ernestognw
ernestognw approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@ernestognw ernestognw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ernestognw ernestognw merged commit db464dd into OpenZeppelin:master Aug 21, 2024
24 checks passed
ernestognw pushed a commit to Amxx/openzeppelin-contracts that referenced this pull request Aug 21, 2024
@cairoeth @ernestognw
Remove double declaration of P in P256 (OpenZeppelin#5159)
4fb8987
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Aug 30, 2024
@Amxx
Revert "Remove double declaration of P in P256 (OpenZeppelin#5159)"
2d5daf4 
This reverts commit db464dd.
@Amxx Amxx mentioned this pull request Aug 30, 2024
Merged
Amxx added a commit that referenced this pull request Aug 30, 2024
@Amxx
Revert "Remove double declaration of P in P256 (#5159)" (#5180)
29a9539
Amxx added a commit to Amxx/openzeppelin-contracts that referenced this pull request Oct 1, 2024
@Amxx
Revert "Remove double declaration of P in P256 (OpenZeppelin#5159)" (…
67ea678 
…OpenZeppelin#5180)

Signed-off-by: Hadrien Croubois <[email protected]>
Amxx pushed a commit that referenced this pull request Oct 2, 2024
@cairoeth @Amxx
Remove double declaration of P in P256 (#5159)
0be114c 
Signed-off-by: Hadrien Croubois <[email protected]>
Amxx added a commit that referenced this pull request Oct 2, 2024
@Amxx
Revert "Remove double declaration of P in P256 (#5159)" (#5180)
6abfe82 
Signed-off-by: Hadrien Croubois <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernestognw ernestognw ernestognw approved these changes

@Amxx Amxx Awaiting requested review from Amxx

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cairoeth @ernestognw