Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for Ownable2Step #4721

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Update docs for Ownable2Step #4721

merged 3 commits into from
Nov 7, 2023

Conversation

ernestognw
Copy link
Member

Replaces #4718

@ernestognw @nventuro
Update docs for Ownable2Step
9abe415 
Co-authored-by: Nicolás Venturo <[email protected]>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 67fb7d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw marked this pull request as ready for review November 6, 2023 16:45
@ernestognw ernestognw mentioned this pull request Nov 6, 2023
Closed
@ernestognw ernestognw requested a review from Amxx November 6, 2023 16:46
Amxx
Amxx previously approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor proposal, otherwise LGTM

docs/modules/ROOT/pages/access-control.adoc Outdated Show resolved Hide resolved
@ernestognw
Copy link
Member Author

Merging since changes include only a suggestion from a previously approved review.

@ernestognw ernestognw enabled auto-merge (squash) November 7, 2023 16:35
@ernestognw ernestognw disabled auto-merge November 7, 2023 16:35
@ernestognw ernestognw merged commit 74016c3 into OpenZeppelin:master Nov 7, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx left review comments

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ernestognw @Amxx