Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for Ownable2Step #4718

Closed
wants to merge 1 commit into from
Closed

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Nov 1, 2023

Going through the docs I noticed there's no explanation of what Ownable2Step is or why it exists, it's just there. I added a brief paragraph going over the motivation.

Copy link

changeset-bot bot commented Nov 1, 2023

⚠️ No Changeset found

Latest commit: 4c6fb8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw
Copy link
Member

@nventuro thanks! I can't checkout to your branch, can you solve the lint issues?

We also need to mention Ownable2Step in the access-control.adoc. I'm compiling a list of changes required to the docs and I'm considering it. No need to add it to this PR but feel free to take it if you think it's worth it as well.

@ernestognw
Copy link
Member

Closing in favor of #4721

@ernestognw ernestognw closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants