This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lite-mode #153
Add lite-mode #153
Changes from 14 commits
cdd7873
0293d87
613f804
892e97b
b12668e
30f593a
5075853
ffbff68
8fa5d1a
d78d334
646a990
dca90b9
3b48e23
5866f8e
343a442
3cbbcdb
96f8aff
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i’m not sure why these two lines use
HOSTS[1]
,PORTS[1]
, andLITE
as args. i guess they’re just placeholder values but if that's the case then it causes a bit of confusion. or do they serve a different purpose?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's to make sure that when these args are explicitly passed, it doesn't cause any issues with the command (like it did with
--account_contract
anddisable_hint_validation
in #150). I'll refactor to make it less confusingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't we testing
args
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I think the weirdness of this test comes from checking the defaults (which differ from args except when explicitly set)