This repository has been archived by the owner on Dec 1, 2023. It is now read-only.
Add lite-mode #153
Merged
Add lite-mode #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martriay
reviewed
Jul 29, 2022
tests/commands/test_node.py
Outdated
Comment on lines
24
to
25
| ([HOSTS[1], PORTS[1]], HOSTS[1], PORTS[1], None), | ||
| ([HOSTS[1], PORTS[1], LITE], HOSTS[1], PORTS[1], LITE), |
There was a problem hiding this comment.
i’m not sure why these two lines use HOSTS[1], PORTS[1], and LITE as args. i guess they’re just placeholder values but if that's the case then it causes a bit of confusion. or do they serve a different purpose?
There was a problem hiding this comment.
It's to make sure that when these args are explicitly passed, it doesn't cause any issues with the command (like it did with --account_contract and disable_hint_validation in #150). I'll refactor to make it less confusing
tests/commands/test_node.py
Outdated
Comment on lines
31
to
35
|
|
||
| command = ["starknet-devnet", "--host", host, "--port", port] | ||
| if mode: | ||
| command.append(mode) | ||
| mock_subprocess.assert_called_once_with(command) |
There was a problem hiding this comment.
Yes! I think the weirdness of this test comes from checking the defaults (which differ from args except when explicitly set)
Co-authored-by: Martín Triay <[email protected]>
…ite-mode' into add-lite-mode
martriay
approved these changes
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supercedes #144 and resolves #116.