Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] cpu usage keeps increasing until crash #98

Closed
JarbasAl opened this issue Mar 17, 2024 · 7 comments
Closed

[BUG] cpu usage keeps increasing until crash #98

JarbasAl opened this issue Mar 17, 2024 · 7 comments
Assignees
Labels
bug Something isn't working severe This breaks the entire program/package or ruins UX

Comments

@JarbasAl
Copy link
Member

when using any audio transformer plugin the cpu usage will continuously increase

replicated with ggwave and fasterwhisper lang detect plugins

reported by @builderjer and verified by @goldyfruit

@JarbasAl JarbasAl added bug Something isn't working severe This breaks the entire program/package or ruins UX labels Mar 17, 2024
@goldyfruit
Copy link
Member

ovos-dinkun-listener never really crashes, process still up and "running" but there is no wakeword detection.

NeonDaniel added a commit to NeonGeckoCom/neon_speech that referenced this issue Apr 25, 2024
…197)

# Description
Rolls back update to ovos-dinkum-listener dependency included in release
4.4.0

# Issues
OpenVoiceOS/ovos-dinkum-listener#98
OpenVoiceOS/ovos-dinkum-listener#107
OpenVoiceOS/ovos-dinkum-listener#110

# Other Notes
<!-- Note any breaking changes, WIP changes, requests for input, etc.
here -->

Co-authored-by: Daniel McKnight <[email protected]>
JarbasAl added a commit to OpenVoiceOS/ovos-plugin-manager that referenced this issue Jun 8, 2024
improve the ReadWriteStream class used by audio transformers

make it threadsafe and more performant by using a deque

add a max size to ensure it doesnt grow forever

maybe fixes undiagnosed issue OpenVoiceOS/ovos-dinkum-listener#98
@JarbasAl
Copy link
Member Author

JarbasAl commented Jun 8, 2024

please test with OpenVoiceOS/ovos-plugin-manager#234

i havent diagnosed the error, but both me an @mikejgray reached the conclusion it must be on that code, so maybe its fixed by the general improvements in that PR

JarbasAl added a commit to OpenVoiceOS/ovos-plugin-manager that referenced this issue Jun 10, 2024
* refactor/improve_readwritestream

improve the ReadWriteStream class used by audio transformers

make it threadsafe and more performant by using a deque

add a max size to ensure it doesnt grow forever

maybe fixes undiagnosed issue OpenVoiceOS/ovos-dinkum-listener#98

* default max sizes
@builderjer
Copy link
Member

Where I noticed the bug the first time was when testing ovos-transformer-plugin-ggwave. When it was enabled and automatically started, CPU usage would continually rise. First indications were at about 5 minutes. By 15 minutes, CPU was at 100 and OVOS was unusable.

Testing now, with OpenVoiceOS/ovos-plugin-manager#234 , it seems to have fixed the problem. I have had ggwave transformer running for 45 minutes and no CPU increase.

@JarbasAl
Copy link
Member Author

closing for now, please re-open if still an issue!

JarbasAl added a commit that referenced this issue Jun 11, 2024
to avoid bug #98
JarbasAl added a commit that referenced this issue Jun 11, 2024
@builderjer builderjer reopened this Jun 15, 2024
@builderjer
Copy link
Member

This is not fixed. After a full day of being activated, my device crashed and it has to do with ovos-ggwave-listener. CPU usage still rises, just not near as fast.

@JarbasAl
Copy link
Member Author

can you replicate with the faster whisper lang detect? just to be sure it isnt a different issue with ggwave plugin itself

  "listener": {
    "audio_transformers": {
        "ovos-audio-transformer-plugin-fasterwhisper": {
            "model": "small"
        }
    }
  }

@builderjer
Copy link
Member

Going to close this and open in ovos-audio-transformer-plugin-ggwave.

With the above configuration, I have had no issues for over 24 hrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severe This breaks the entire program/package or ruins UX
Projects
None yet
Development

No branches or pull requests

4 participants